linux-kernel - Re: [PATCH 1/4] ARM: dts: bcmbca: fix arch timer node cpu mask flag value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <166f2a6f-7608-d0a1-a316-8885295e3900@gmail.com>
Date:   Mon, 1 Aug 2022 08:31:55 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     William Zhang <william.zhang@...adcom.com>,
        Linux ARM List <linux-arm-kernel@...ts.infradead.org>
Cc:     Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        kursad.oney@...adcom.com, dan.beygelman@...adcom.com,
        f.fainelli@...il.com, anand.gore@...adcom.com,
        joel.peshkin@...adcom.com,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: bcmbca: fix arch timer node cpu mask flag
 value

Hi William,

On 7/28/2022 6:50 PM, William Zhang wrote:
> The cpu mask flag value should match the number of cpu cores in the
> chip. Correct the value accordingly for BCM63178, BCM6846 and BCM6878.
> 
> Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
> Fixes: de1a99ac0b64 ("ARM: dts: Add DTS files for bcmbca SoC BCM6846")
> Fixes: 6bcad714e173 ("ARM: dts: Add DTS files for bcmbca SoC BCM6878")
> 
> Signed-off-by: William Zhang <william.zhang@...adcom.com>

This looks fine, if you could split one patch per file you modify that 
would look a bit better, this is particularly relevant for bug fixes so 
if you can split patch 1 into 3, patch 2 into 2 and patch 3 into 2 that 
would be great. Patch 4 can be taken as is since it is sort of a 
bca-wide cleanup.

Right now all of those changes went into the same release cycle, but in 
the future that might not be the case.

Thank you!
-- 
Florian