linux-kernel - Re: [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1688f1aad1f7239e5b0eb3d45a854ca6b0e61e1a.camel@mediatek.com>
Date:   Tue, 2 Aug 2022 17:43:10 +0800
From:   Jianjun Wang <jianjun.wang@...iatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>
CC:     <linux-pci@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Ryder Lee <ryder.lee@...iatek.com>, <Rex-BC.Chen@...iatek.com>,
        <TingHan.Shen@...iatek.com>, <Liju-clr.Chen@...iatek.com>,
        <Jian.Yang@...iatek.com>
Subject: Re: [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for
 MT8188 and MT8195

Hi Krzysztof,

Thanks for your comment.

On Tue, 2022-08-02 at 10:59 +0200, Krzysztof Kozlowski wrote:
> On 01/08/2022 13:37, Jianjun Wang wrote:
> > MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as
> > MT8192.
> > 
> > Also add new clock name "peri_mem" since the MT8188 and MT8195 use
> > clock
> > "peri_mem" instead of "top_133m".
> > 
> > Signed-off-by: Jianjun Wang <jianjun.wang@...iatek.com>
> > ---
> > Changes in v3:
> > Use enum property to add the new clock name.
> > 
> > Changes in v2:
> > Merge two patches into one.
> > ---
> >  .../bindings/pci/mediatek-pcie-gen3.yaml           | 14
> > ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 0499b94627ae..a0ca9c7f5dfa 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,14 @@ allOf:
> >  
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8192-pcie
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-pcie
> > +              - mediatek,mt8195-pcie
> > +          - const: mediatek,mt8192-pcie
> > +      - items:
> 
> You have one item, so this is just const. Or enum if  you expect it
> to
> grow soon.

It makes sense, I'll remove this "items" and just keep the const item
in the next version.

Thanks.
> 
> > +          - const: mediatek,mt8192-pcie
> >  
> >    reg:
> >      maxItems: 1
> > @@ -84,7 +91,9 @@ properties:
> >        - const: tl_96m
> >        - const: tl_32k
> >        - const: peri_26m
> > -      - const: top_133m
> > +      - enum:
> > +          - top_133m        # for MT8192
> > +          - peri_mem        # for MT8188/MT8195
> 
> This requires allOf:if:then restricting it further per variant.
> 
> 
> 
> Best regards,
> Krzysztof