linux-kernel - Re: [PATCH v3 00/13] PM6125 regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89469b0d-e6aa-4d60-c93c-a99256f65445@linaro.org>
Date:   Wed, 3 Aug 2022 11:06:08 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Iskren Chernev <iskren.chernev@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mark Brown <broonie@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Robert Marko <robimarko@...il.com>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v3 00/13] PM6125 regulator support

On 01/08/2022 01:37, Iskren Chernev wrote:
> This patch series adds SPMI and SMD regulator support for the PM6125 found on
> SM4250/SM6115 SoCs from QCom.
> 
> This code has been tested on:
> * OnePlus Nord N100 (oneplus,billie2, SoC sm4250)
> * Redmi 9T (redmi,lemon, SoC sm6115)
> 
> The main source used for this change is qpnp pm6125 support patch from caf [1]:
> 
> [1]: https://source.codeaurora.org/quic/la/kernel/msm-5.4/commit/?h=kernel.lnx.5.4.r1-rel&id=d1220daeffaa440ffff0a8c47322eb0033bf54f5
> 
> v2: https://lkml.org/lkml/2022/7/26/885
> v1: https://lkml.org/lkml/2021/8/28/144
> 
> Changes from v2:
> - split spmi new regulator support in 2 patches
> - FTS and LDOs now have set_load and set_pull_down ops
> - add better commit messages on spmi patches
> - fix sob header order
> - fix tested device info (Redmi 9T, NOT Xiaomi 9T)
> - improve formatting in spmi binding docs
> - sort alphabetically in smd binding docs
> - sort alphabetically spmi pmics
> - sort alphabetically smd pmics
> Changes from v1:
> - add dt-bindings
> - split SPMI patch into new reg types and the new PMIC
> - add correct supply mapping
> 
> Iskren Chernev (13):
>    dt-bindings: regulator: qcom_spmi: Improve formatting of if-then
>      blocks
>    dt-bindings: regulator: qcom_spmi: Document PM6125 PMIC
>    dt-bindings: regulator: qcom_smd: Sort compatibles alphabetically
>    dt-bindings: regulator: qcom_smd: Document PM6125 PMIC
>    regulator: qcom_spmi: Add support for new regulator types
>    regulator: qcom_spmi: Add support for HFSMPS regulator type
>    regulator: qcom_spmi: Sort pmics alphabetically (part 1)
>    regulator: qcom_spmi: Sort pmics alphabetically (part 2)
>    regulator: qcom_spmi: Add PM6125 PMIC support
>    regulator: qcom_smd: Sort pmics alphabetically (part 1)
>    regulator: qcom_smd: Sort pmics alphabetically (part 2)
>    regulator: qcom_smd: Sort pmics alphabetically (part 3)

What is the reason for these part1/2 and part1/2/3 splits? I think you 
can collapse them into two respective patches, one sorting of spmi, 
another one sorting the smd regulators

>    regulator: qcom_smd: Add PM6125 regulators support
> 
>   .../regulator/qcom,smd-rpm-regulator.yaml     |  26 +-
>   .../regulator/qcom,spmi-regulator.yaml        |  32 ++
>   drivers/regulator/qcom_smd-regulator.c        | 400 ++++++++++--------
>   drivers/regulator/qcom_spmi-regulator.c       | 383 ++++++++++++-----
>   4 files changed, 556 insertions(+), 285 deletions(-)
> 


-- 
With best wishes
Dmitry