linux-kernel - Re: [PATCH v3 00/13] PM6125 regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f44fc6d2-9d3b-2c37-15dd-d002dc09b7b0@gmail.com>
Date:   Wed, 3 Aug 2022 11:58:26 +0300
From:   Iskren Chernev <iskren.chernev@...il.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mark Brown <broonie@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Robert Marko <robimarko@...il.com>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v3 00/13] PM6125 regulator support


>>
>> Iskren Chernev (13):
>>    dt-bindings: regulator: qcom_spmi: Improve formatting of if-then
>>      blocks
>>    dt-bindings: regulator: qcom_spmi: Document PM6125 PMIC
>>    dt-bindings: regulator: qcom_smd: Sort compatibles alphabetically
>>    dt-bindings: regulator: qcom_smd: Document PM6125 PMIC
>>    regulator: qcom_spmi: Add support for new regulator types
>>    regulator: qcom_spmi: Add support for HFSMPS regulator type
>>    regulator: qcom_spmi: Sort pmics alphabetically (part 1)
>>    regulator: qcom_spmi: Sort pmics alphabetically (part 2)
>>    regulator: qcom_spmi: Add PM6125 PMIC support
>>    regulator: qcom_smd: Sort pmics alphabetically (part 1)
>>    regulator: qcom_smd: Sort pmics alphabetically (part 2)
>>    regulator: qcom_smd: Sort pmics alphabetically (part 3)
>
> What is the reason for these part1/2 and part1/2/3 splits? I think you can collapse them into two respective patches, one sorting of spmi, another one sorting the smd regulators

The reason is that if I do collapse them the diff looks much more
complicated and it's not obvious that the sections are in-fact only moved.
I'm not sure how these are reviewed, but casually reading the patch will
not instill confidence.