linux-kernel - [PATCH] crypto: keembay-ocs - Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220803224755.177de90e@endymion.delvare>
Date:   Wed, 3 Aug 2022 22:47:55 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     LKML <linux-kernel@...r.kernel.org>, linux-crypto@...r.kernel.org
Cc:     Declan Murphy <declan.murphy@...el.com>,
        Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Prabhjot Khurana <prabhjot.khurana@...el.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: [PATCH] crypto: keembay-ocs - Drop obsolete dependency on
 COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Declan Murphy <declan.murphy@...el.com>
Cc: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
Cc: Mark Gross <mgross@...ux.intel.com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Prabhjot Khurana <prabhjot.khurana@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>
---
 drivers/crypto/keembay/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-5.18.orig/drivers/crypto/keembay/Kconfig	2022-05-22 21:52:31.000000000 +0200
+++ linux-5.18/drivers/crypto/keembay/Kconfig	2022-08-03 22:36:27.354500492 +0200
@@ -42,7 +42,7 @@ config CRYPTO_DEV_KEEMBAY_OCS_AES_SM4_CT
 config CRYPTO_DEV_KEEMBAY_OCS_ECC
 	tristate "Support for Intel Keem Bay OCS ECC HW acceleration"
 	depends on ARCH_KEEMBAY || COMPILE_TEST
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on HAS_IOMEM
 	select CRYPTO_ECDH
 	select CRYPTO_ENGINE
@@ -64,7 +64,7 @@ config CRYPTO_DEV_KEEMBAY_OCS_HCU
 	select CRYPTO_ENGINE
 	depends on HAS_IOMEM
 	depends on ARCH_KEEMBAY || COMPILE_TEST
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	  Support for Intel Keem Bay Offload and Crypto Subsystem (OCS) Hash
 	  Control Unit (HCU) hardware acceleration for use with Crypto API.


-- 
Jean Delvare
SUSE L3 Support