linux-kernel - Re: [PATCH] crypto: keembay-ocs - Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yv9twQnbmqrLCDcV@gondor.apana.org.au>
Date:   Fri, 19 Aug 2022 19:02:25 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-crypto@...r.kernel.org,
        Declan Murphy <declan.murphy@...el.com>,
        Daniele Alessandrelli <daniele.alessandrelli@...el.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Prabhjot Khurana <prabhjot.khurana@...el.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] crypto: keembay-ocs - Drop obsolete dependency on
 COMPILE_TEST

On Wed, Aug 03, 2022 at 10:47:55PM +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Declan Murphy <declan.murphy@...el.com>
> Cc: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> Cc: Mark Gross <mgross@...ux.intel.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Prabhjot Khurana <prabhjot.khurana@...el.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> ---
>  drivers/crypto/keembay/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt