linux-kernel - Re: [PATCH v2 02/10] dt-bindings: iio: accel: use spi-peripheral-props.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220803212926.GA2639296-robh@kernel.org>
Date:   Wed, 3 Aug 2022 15:29:26 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lucas Stankus <lucas.p.stankus@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Tomislav Denis <tomislav.denis@....com>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Ricardo Ribalda <ribalda@...nel.org>,
        Dragos Bogdan <dragos.bogdan@...log.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Stefan Popa <stefan.popa@...log.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        Joachim Eastwood <manabian@...il.com>,
        Tomas Melin <tomas.melin@...sala.com>,
        Sean Nyekjaer <sean@...nix.com>,
        Beniamin Bia <beniamin.bia@...log.com>,
        Patrick Vasseur <patrick.vasseur@....fr>,
        Charles-Antoine Couret <charles-antoine.couret@...ensium.com>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Philippe Reynes <tremyfr@...oo.fr>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Alexandru Lazar <alazar@...rtmail.com>,
        Oskar Andero <oskar.andero@...il.com>,
        Mårten Lindahl <martenli@...s.com>,
        Bogdan Pricop <bogdan.pricop@...tex.com>,
        Angelo Compagnucci <angelo.compagnucci@...il.com>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Dan Murphy <dmurphy@...com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Michael Welling <mwelling@...e.org>,
        Lukas Wunner <lukas@...ner.de>,
        Robert Jones <rjones@...eworks.com>,
        Chris Coffey <cmc@...blebit.net>,
        Slawomir Stepien <sst@...zta.fm>,
        Sankar Velliangiri <navin@...umiz.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        broonie@...nel.org
Subject: Re: [PATCH v2 02/10] dt-bindings: iio: accel: use
 spi-peripheral-props.yaml

On Sun, Jul 31, 2022 at 04:49:43PM +0100, Jonathan Cameron wrote:
> On Wed, 27 Jul 2022 18:46:38 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> > Instead of listing directly properties typical for SPI peripherals,
> > reference the spi-peripheral-props.yaml schema.  This allows using all
> > properties typical for SPI-connected devices, even these which device
> > bindings author did not tried yet.
> > 
> > Remove the spi-* properties which now come via spi-peripheral-props.yaml
> > schema, except for the cases when device schema adds some constraints
> > like maximum frequency.
> > 
> > While changing additionalProperties->unevaluatedProperties, put it in
> > typical place, just before example DTS.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > 
> > ---
> > 
> > I wonder if spi-3wire is device specific (not controller) and should be
> > rather explicitly mentioned by device schema. Just like spi-cpol/cpha.
> 
> I think it is, but Mark is expert on this.

I would say yes as it's the device with a single data line.

> In general I'm waiting on Mark's opinion on the whole idea!

The prerequisite changes (except for spi-3-wire) are already queued up 
by Mark as are changes for other subsystems.

Rob