linux-kernel - Re: [PATCH v2 00/10] dt-bindings: iio: use spi-peripheral-props.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220803214000.GB2639296-robh@kernel.org>
Date:   Wed, 3 Aug 2022 15:40:00 -0600
From:   Rob Herring <robh@...nel.org>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lucas Stankus <lucas.p.stankus@...il.com>,
        Puranjay Mohan <puranjay12@...il.com>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Marcus Folkesson <marcus.folkesson@...il.com>,
        Kent Gustavsson <kent@...oris.se>,
        Tomislav Denis <tomislav.denis@....com>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Ricardo Ribalda <ribalda@...nel.org>,
        Dragos Bogdan <dragos.bogdan@...log.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@...ensense.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Stefan Popa <stefan.popa@...log.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Mike Looijmans <mike.looijmans@...ic.nl>,
        Joachim Eastwood <manabian@...il.com>,
        Tomas Melin <tomas.melin@...sala.com>,
        Sean Nyekjaer <sean@...nix.com>,
        Beniamin Bia <beniamin.bia@...log.com>,
        Patrick Vasseur <patrick.vasseur@....fr>,
        Charles-Antoine Couret <charles-antoine.couret@...ensium.com>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Philippe Reynes <tremyfr@...oo.fr>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Alexandru Lazar <alazar@...rtmail.com>,
        Oskar Andero <oskar.andero@...il.com>,
        Mårten Lindahl <martenli@...s.com>,
        Bogdan Pricop <bogdan.pricop@...tex.com>,
        Angelo Compagnucci <angelo.compagnucci@...il.com>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Dan Murphy <dmurphy@...com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Phil Reid <preid@...ctromag.com.au>,
        Michael Welling <mwelling@...e.org>,
        Robert Jones <rjones@...eworks.com>,
        Chris Coffey <cmc@...blebit.net>,
        Slawomir Stepien <sst@...zta.fm>,
        Sankar Velliangiri <navin@...umiz.com>,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v2 00/10] dt-bindings: iio: use spi-peripheral-props.yaml

On Mon, Aug 01, 2022 at 06:04:10PM +0200, Lukas Wunner wrote:
> On Mon, Aug 01, 2022 at 05:45:07PM +0200, Krzysztof Kozlowski wrote:
> > On 31/07/2022 00:46, Lukas Wunner wrote:
> > > On Wed, Jul 27, 2022 at 06:46:36PM +0200, Krzysztof Kozlowski wrote:
> > >>  78 files changed, 324 insertions(+), 249 deletions(-)
> > > 
> > > Pardon me for being dense, but what is the benefit of this series
> > > that justifies inflating the schema definitions by a total of 75 lines?
> > 
> > The commits were explaining rationale, so let me bring it here. The
> > benefits are:
> > This allows using all properties typical for SPI-connected devices, even
> > these which device bindings author did not tried yet.
> 
> How do you know these untested properties work with the devices to which
> you're adding them?

How do we know anything DT works? We don't without testing on h/w. 
That's not what the schemas provide.

The spi-peripheral-props.yaml reference is needed in order to allow 
controller specific timing properties and to prevent random 
other undocumented properties from being present. There is not another 
way to do both of those.

Do I wish we didn't have these controller specific timing parameters, 
yes! But that ship has sailed.

Rob