linux-kernel - Re: [git pull] vfs.git pile 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wh6VSqsnANHkQpw=yD-Hkt90Y1LX=ad9+r+SusfriUOfA@mail.gmail.com>
Date:   Wed, 3 Aug 2022 16:42:43 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs.git pile 3 - dcache

On Wed, Aug 3, 2022 at 4:24 PM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Wed, Aug 03, 2022 at 06:59:36PM -0400, Steven Rostedt wrote:
> >
> >       preempt_disable_inlock() ?
>
> preempt_disable_locked()?

Heh. Shed painting in full glory.

Let's try just "preempt_enable_under_spinlock()" and see.

It's a bit long, but it's still shorter than the existing usage pattern.

And we don't have "inlock" anywhere else, and while "locked" is a real
pattern we have, it tends to be about other things (ie "I hold the
lock that you need, so don't take it").

And this is _explicitly_ only about spinning locks, because sleeping
locks don't do the preemption disable even without RT.

So let's make it verbose and clear and unambiguous. It's not like I
expect to see a _lot_ of those. Knock wood.

We had a handful of those things before (in mm/vmstat, and now added
another case to the dentry code. So it has become a pattern, but I
really really hope it's not exactly a common pattern.

And so because it's not common, typing a bit more is a good idea - and
making it really clear is probably also a good idea.

                Linus