[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <10887a45-cd28-8396-b3e7-745e22e00c27@linaro.org>
Date: Thu, 4 Aug 2022 13:23:38 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jai Luthra <j-luthra@...com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: sound: tlv320aic3x: Convert to dtschema
On 03/08/2022 17:17, Jai Luthra wrote:
> Convert bindings for TI's TLV320AIC3x audio codecs to dtschema.
>
> Signed-off-by: Jai Luthra <j-luthra@...com>
> ---
> .../bindings/sound/ti,tlv320aic3x.yaml | 158 ++++++++++++++++++
> .../devicetree/bindings/sound/tlv320aic3x.txt | 97 -----------
> 2 files changed, 158 insertions(+), 97 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/tlv320aic3x.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml
> new file mode 100644
> index 000000000000..f0ed856162ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320aic3x.yaml
> @@ -0,0 +1,158 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,tlv320aic3x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TLV320AIC3x Codec
> +
> +description: |
> + TLV320AIC3x are a series of low-power stereo audio codecs with stereo
> + headphone amplifier, as well as multiple inputs and outputs programmable in
> + single-ended or fully differential configurations.
> +
> + The serial control bus supports SPI or I2C protocols, while the serial audio
> + data bus is programmable for I2S, left/right-justified, DSP, or TDM modes.
> +
> + The following pins can be referred in the sound node's audio routing property:
> +
> + CODEC output pins:
> + LLOUT
> + RLOUT
> + MONO_LOUT
> + HPLOUT
> + HPROUT
> + HPLCOM
> + HPRCOM
> +
> + CODEC input pins for TLV320AIC3104:
> + MIC2L
> + MIC2R
> + LINE1L
> + LINE1R
> +
> + CODEC input pins for other compatible codecs:
> + MIC3L
> + MIC3R
> + LINE1L
> + LINE2L
> + LINE1R
> + LINE2R
> +
> +maintainers:
> + - Jai Luthra <j-luthra@...com>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tlv320aic3x
> + - ti,tlv320aic33
> + - ti,tlv320aic3007
> + - ti,tlv320aic3106
> + - ti,tlv320aic3104
> +
> + reg:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + GPIO specification for the active low RESET input.
> +
> + gpio-reset:
> + maxItems: 1
> + description:
> + Deprecated, please use reset-gpios instead.
> + deprecated: true
> +
> + ai3x-gpio-func:
> + description: AIC3X_GPIO1 & AIC3X_GPIO2 Functionality
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 2
No need for minItems if they equal to maxItems.
> + maxItems: 2
> +
Except that, Rob's bot reports several other properties used in DTS. You
can document them in that commit - just mention in commit msg - or a
follow-up commit just for undocumented properties.
Best regards,
Krzysztof
Powered by blists - more mailing lists