linux-kernel - Re: [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YuustIMaImn+0UYc@kroah.com>
Date:   Thu, 4 Aug 2022 13:25:40 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ray Hung <tw.rayhung@...il.com>
Cc:     balbi@...nel.org, akpm@...ux-foundation.org, dh10.jung@...sung.com,
        songmuchun@...edance.com, dan.carpenter@...cle.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: rndis: use %u instead of %d to print u32
 values

On Thu, Aug 04, 2022 at 07:08:36PM +0800, Ray Hung wrote:
> The driver uses the %d format to print u32 values. The correct
> format is %u. Fix it.
> 
> Signed-off-by: Ray Hung <tw.rayhung@...il.com>
> ---
>  drivers/usb/gadget/function/rndis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
> index 713efd9aefde..10ba339bcea4 100644
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v)
>  			 "used      : %s\n"
>  			 "state     : %s\n"
>  			 "medium    : 0x%08X\n"
> -			 "speed     : %d\n"
> +			 "speed     : %u\n"
>  			 "cable     : %s\n"
>  			 "vendor ID : 0x%08X\n"
>  			 "vendor    : %s\n",
> -- 
> 2.25.1
> 

What commit id does this fix?

And given this is only for debugging, there's no rush, right?

thanks,

greg k-h