linux-kernel - Re: [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8757e6d6-666b-433f-3089-621e7c80cf9e@tom-fitzhenry.me.uk>
Date:   Sun, 7 Aug 2022 01:22:25 +1000
From:   Tom Fitzhenry <tom@...-fitzhenry.me.uk>
To:     Tudor.Ambarus@...rochip.com, p.yadav@...com, michael@...le.cc,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com
Cc:     linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128

On 21/7/22 18:08, Tudor.Ambarus@...rochip.com wrote:
> Does this flash implement the manufacturer ID continuation codes?
> Can you read more bytes of manufacturer ID and dump them?

I'm not sure how to do this, but from what I can gather, flash chips 
that implement manufacturer ID continuation codes return >3 bytes in 
response to RDID. Is this correct?

To do this, in tools/spi/spidex_fdx.c I set buf[0] = 0x9F, and then 
executed this with a large recvbuf:

$ sudo ./a.out -m 6 /dev/spidev0.0
/dev/spidev0.0: spi mode 0x0, 8 bits per word, 10000000 Hz max
response( 6,  7):  25 70 18 25 70 18

It looks like the 3-byte response has cycled, suggesting this flash chip 
does not implement continuation codes.

> If the flash does not define the continuation codes, we'll need to
> add this flash in a ID collisions driver.

I will do this in v3.