linux-kernel - Re: [RFC PATCH 6/6] crypto: sa2ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Aug 2022 14:52:13 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Daniel Parks <danielrparks@...com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>
Cc:     linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH 6/6] crypto: sa2ul_pka: Add SA2UL PKA driver

Hi--

On 8/8/22 12:12, Daniel Parks wrote:
> diff --git a/drivers/crypto/sa2ul_pka/Kconfig b/drivers/crypto/sa2ul_pka/Kconfig
> new file mode 100644
> index 000000000000..c4f87b14878e
> --- /dev/null
> +++ b/drivers/crypto/sa2ul_pka/Kconfig
> @@ -0,0 +1,26 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config CRYPTO_DEV_SA2UL_PKA
> +	tristate "Support for TI security accelerator public-key module"
> +	depends on CRYPTO_DEV_SA2UL || COMPILE_TEST
> +	select ARM64_CRYPTO
> +	select CRYPTO_AKCIPHER
> +	select CRYPTO_RSA
> +	select PACKING
> +	select CRYPTO_DH
> +	help
> +		The K3 security accelerator engine contains a public-key
> +		cryptography module. Select this if you want to use hardware
> +		acceleration for asymmetric cryptography on these devices. This
> +		engine is not available to the Linux cores on most devices; check
> +		your device tree if unsure.
> +
> +config CRYPTO_DEV_SA2UL_PKA_DEBUG
> +	bool "Debugging options for TI security accelerator public-key module"
> +	depends on CRYPTO_DEV_SA2UL_PKA
> +	default n
> +	help
> +		Enables the module options 'snapshot' and 'poison_mem' to assist
> +		in debugging the PKA driver. Choosing "y" will allow the root user
> +		to extract cryptographic keys from the driver, so do not enable in
> +		a production build.

Too much help text indentation.

from Documentation/process/coding-style.rst:

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

-- 
~Randy