linux-kernel - Re: [RFC PATCH 1/6] dt-bindings: crypto: ti,sa2ul: add pka subdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c97e7080-9d93-ae09-9bb2-106539f9b1ae@linaro.org>
Date:   Tue, 9 Aug 2022 08:44:15 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Daniel Parks <danielrparks@...com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>
Cc:     linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH 1/6] dt-bindings: crypto: ti,sa2ul: add pka subdevice

On 08/08/2022 22:12, Daniel Parks wrote:
> The PKA (aka eip29t2) is a subdevice of the SA2UL on k3.
> 
> Signed-off-by: Daniel Parks <danielrparks@...com>
> ---
>  Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 02f47c2e7998..e4adb8192608 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -64,8 +64,14 @@ patternProperties:
>      type: object
>      description:
>        Child RNG node for SA2UL
>  
> +patternProperties:
> +  "^pka@[a-f0-9]+$":
> +    type: object
> +    description:
> +      Child PKA node for SA2UL

If PKA is from "Public Key Accelerator", could you include here full
name of the abbreviation?

Anyway you need here reference to schema for your node or describe the
contents.

Best regards,
Krzysztof