linux-kernel - Re: [RFC PATCH 2/6] dt-bindings: crypto: add binding for eip29t2 public key accelerator (PKA)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2ce0563-86fc-6049-ee53-b45753335352@linaro.org>
Date:   Tue, 9 Aug 2022 08:47:01 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Daniel Parks <danielrparks@...com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>
Cc:     linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH 2/6] dt-bindings: crypto: add binding for eip29t2
 public key accelerator (PKA)

On 08/08/2022 22:12, Daniel Parks wrote:
> The PKA is a mmio-only asymmetric crypto accelerator available on
> certain K3 devices.
> 
> Signed-off-by: Daniel Parks <danielrparks@...com>
> ---
>  .../inside-secure,safexcel-eip29t2.yaml       | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml
> 
> diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml
> new file mode 100644
> index 000000000000..b1e195a108cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip29t2.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/inside-secure,safexcel-eip29t2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: K3 SoC SA2UL PKA crypto module

If this is the child mentioned in patch #1, then this should be first
patch and your next one should reference it.

> +
> +maintainers:
> +  - Daniel Parks <danielrparks@...com>
> +
> +description: |
> +  Asymmetric crypto accelerator
> +
> +properties:
> +  compatible:
> +    const: inside-secure,safexcel-eip29t2
> +
> +  reg:
> +    items:
> +      - description: control registers
> +      - description: mapped memory
> +
> +  interrupts:
> +    items:
> +      - description: PKA interrupt

This could be "maxItems:1" because your description actually does not
bring anything new, but current choice is also OK.

Best regards,
Krzysztof