linux-kernel - Re: [PATCH] af_key: Do not call xfrm_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Aug 2022 07:47:28 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Abhishek Shah <abhishek.shah@...umbia.edu>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <pabeni@...hat.com>, <linux-kernel@...r.kernel.org>,
        Gabriel Ryan <gabe@...columbia.edu>,
        Fan Du <fan.du@...driver.com>,
        Steffen Klassert <klassert@...nel.org>
Subject: Re: [PATCH] af_key: Do not call xfrm_probe_algs in parallel

On Thu, Aug 04, 2022 at 06:03:46PM +0800, Herbert Xu wrote:
> When namespace support was added to xfrm/afkey, it caused the
> previously single-threaded call to xfrm_probe_algs to become
> multi-threaded.  This is buggy and needs to be fixed with a mutex.
> 
> Reported-by: Abhishek Shah <abhishek.shah@...umbia.edu>
> Fixes: 283bc9f35bbb ("xfrm: Namespacify xfrm state/policy locks")
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks a lot Herbert!