linux-kernel - Re: [PATCH] asm-generic: Conditionally enable do_softirq_own

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Aug 2022 23:42:29 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
Subject: Re: [PATCH] asm-generic: Conditionally enable do_softirq_own_stack()
 via Kconfig.

On Tue, Aug 9, 2022 at 5:57 PM Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
>
> Remove the CONFIG_PREEMPT_RT symbol from the ifdef around
> do_softirq_own_stack() and move it to Kconfig instead.
>
> Enable softirq stacks based on SOFTIRQ_ON_OWN_STACK which depends on
> HAVE_SOFTIRQ_ON_OWN_STACK and its default value is set to !PREEMPT_RT.
> This ensures that softirq stacks are not used on PREEMPT_RT and avoids
> a 'select' statement on an option which has a 'depends' statement.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  arch/Kconfig                          | 4 ++++
>  arch/arm/kernel/irq.c                 | 2 +-
>  arch/parisc/kernel/irq.c              | 2 +-
>  arch/powerpc/kernel/irq.c             | 4 ++--
>  arch/s390/include/asm/softirq_stack.h | 2 +-
>  arch/sh/kernel/irq.c                  | 2 +-
>  arch/sparc/kernel/irq_64.c            | 2 +-
>  arch/x86/include/asm/irq_stack.h      | 2 +-
>  arch/x86/kernel/irq_32.c              | 2 +-
>  include/asm-generic/softirq_stack.h   | 2 +-

Thanks for the patch, I assume Linus will want to pick this up himself.
Let me know if I should give it a spin in the asm-generic tree first for
additional build testing.

Acked-by: Arnd Bergmann <arnd@...db.de>