linux-kernel - Re: 回复: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvJ5xxsDxC4q3fJB@zn.tnic>
Date:   Tue, 9 Aug 2022 17:14:15 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Kani, Toshi" <toshi.kani@....com>
Cc:     Justin He <Justin.He@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, James Morse <James.Morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>
Subject: Re: 回复: [PATCH] ACPI: APEI:
 move edac_init ahead of ghes platform drv register

On Tue, Aug 09, 2022 at 02:36:33PM +0000, Kani, Toshi wrote:
> The logic needs to be latched on ghes presence, i.e., the condition is

If GHES is not enabled, there'll of course be a stub which returns
false.

> Agree that changing all edac drivers to check with GHES is an option.

Not all - all relevant drivers for your - HPE - use case. We don't load
ghes_edac on anything else. Known-good platforms only, remember?

> In this approach, though, they will need to check with foo_preferred()
> when a new FW interface FOO is introduced.

I'm afraid I don't understand what you mean here.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette