linux-kernel - RE: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR84MB1838B57BCEBEF1D8E02CD12D82629@PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Tue, 9 Aug 2022 14:57:25 +0000
From:   "Kani, Toshi" <toshi.kani@....com>
To:     Justin He <Justin.He@....com>, Borislav Petkov <bp@...en8.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     Len Brown <lenb@...nel.org>, James Morse <James.Morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Robert Richter" <rric@...nel.org>,
        Shuai Xue <xueshuai@...ux.alibaba.com>,
        "Jarkko Sakkinen" <jarkko@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:EDAC-CORE" <linux-edac@...r.kernel.org>
Subject: RE: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv
 register

On Tuesday, August 9, 2022 4:06 AM, Justin He wrote:
> > ghes_edac_init() is called from the normal module init path, e.g.,
> > module_init().
> Thanks for the suggestion, one gap is that under module_init path, how can
> we pass the 2nd parameter of ghes_edac_register (struct device *dev) to
> the new * ghes_edac_init()?
> 
> IIUC, the parameter of any functions under module_init() path should be
> void.

Since simpler version of ghes_edac_register() is still called with 
the parameters first, it can save *dev to a ghes_edac structure for
ghes_edac_init() to use.

Toshi