linux-kernel - Re: [PATCH v3] mm: add thp_utilization metrics to /proc/thp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1F8B9D85-A735-4832-AD58-CA4BD474248D@fb.com>
Date:   Tue, 9 Aug 2022 17:15:47 +0000
From:   "Alex Zhu (Kernel)" <alexlzhu@...com>
To:     Yang Shi <shy828301@...il.com>
CC:     Rik van Riel <riel@...com>, Kernel Team <Kernel-team@...com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "willy@...radead.org" <willy@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3] mm: add thp_utilization metrics to
 /proc/thp_utilization


> OK, it is hard to tell what it looks like now. But the THPs on the
> deferred split list may be on the "low utilization split" list too?
> IIUC the major difference is to replace zero-filled subpage to special
> zero page, so you implemented another THP split function to handle it?
> 
> Anyway the code should answer the most questions.

They can indeed end up on both lists. This did have to be handled when 
implementing the shrinker. 

We free the zero filled subpages, while modifying the existing split_huge_page()
function. Will follow up that change in another patch.