linux-kernel - Re: [PATCH] spi: meson-spicc: save pow2 datarate between messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvPFZZ2HT2zK9XjQ@sirena.org.uk>
Date:   Wed, 10 Aug 2022 15:49:09 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Da Xue <da@...re.computer>
Subject: Re: [PATCH] spi: meson-spicc: save pow2 datarate between messages

On Wed, Aug 10, 2022 at 04:40:04PM +0200, Neil Armstrong wrote:

> I don't think it's worth adding so much code for this since we already

I don't recall the code for clock providers being that hard?  They're
generally pretty small, some of the ASoC CODEC drivers did something
similar.

> had an open-coded function which perfectly worked before.

Except in the cases it didn't...

> I'm perfectly OK to remove the CCF driver for the legacy clock path
> and return back to the old open coded calculation since it perfectly
> worked and stop using the legacy clock path for new SoCs since it would
> never be selected anyway...

It does seem better to go the clock provider route TBH.

> ... but GX SoCs are broken so it would need an intermediate fix until
> I push the refactoring to cleanup all this.

I'm trying to figure out if this is actually fixing the problem or just
papering over one case where things happened to go badly.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)