linux-kernel - Re: [RFC][PATCH 3/3] kselftest: Add drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YvPgCRqMz1bw9gmI@phenom.ffwll.local>
Date:   Wed, 10 Aug 2022 18:42:49 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     John Stultz <jstultz@...gle.com>
Cc:     Christian König <christian.koenig@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Jason Ekstrand <jason@...kstrand.net>,
        Lionel Landwerlin <lionel.g.landwerlin@...el.com>,
        Chunming Zhou <david1.zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Shuah Khan <shuah@...nel.org>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [RFC][PATCH 3/3] kselftest: Add drm_syncobj API test tool

On Tue, Jul 12, 2022 at 08:52:53AM -0700, John Stultz wrote:
> On Tue, Jul 12, 2022 at 12:43 AM Christian König
> <christian.koenig@....com> wrote:
> > Am 12.07.22 um 06:22 schrieb John Stultz:
> > > An initial pass at a drm_syncobj API test.
> > >
> > > Currently covers trivial use of:
> > >    DRM_IOCTL_SYNCOBJ_CREATE
> > >    DRM_IOCTL_SYNCOBJ_DESTROY
> > >    DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD
> > >    DRM_IOCTL_SYNCOBJ_FD_TO_HANDLE
> > >    DRM_IOCTL_SYNCOBJ_WAIT
> > >    DRM_IOCTL_SYNCOBJ_RESET
> > >    DRM_IOCTL_SYNCOBJ_SIGNAL
> > >    DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT
> > >    DRM_IOCTL_SYNCOBJ_TIMELINE_SIGNAL
> > >
> > > And demonstrates how the userspace API can be used, along with
> > > some fairly simple bad parameter checking.
> > >
> > > The patch includes a few helpers taken from libdrm, as at least
> > > on the VM I was testing with, I didn't have a new enough libdrm
> > > to support the *_TIMELINE_* ioctls. Ideally the ioctl-helper bits
> > > can be dropped at a later time.
> > >
> > > Feedback would be appreciated!
> >
> > DRM userspace selftests usually go either into libdrm or igt and not
> > into the kernel source.
> 
> Appreciate the pointer, I'll rework and submit to one of those projects.

https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#testing-and-validation

There should be already a ton of syncobj tests, so probably more just work
needed to make them work on vgem so we can test them all without a
suitable hw driver loaded.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch