linux-kernel - Re: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220811092543.696a5ef2@kernel.org>
Date:   Thu, 11 Aug 2022 09:25:43 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Emeel Hakim <ehakim@...dia.com>
Cc:     <edumazet@...gle.com>, <mayflowerera@...il.com>,
        <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Raed Salem <raeds@...dia.com>
Subject: Re: [PATCH net 1/1] net: macsec: Fix XPN properties passing to
 macsec offload

On Tue, 9 Aug 2022 13:29:05 +0300 Emeel Hakim wrote:
> Currently macsec invokes HW offload path before reading extended
> packet number (XPN) related user properties i.e. salt and short
> secure channel identifier (ssci), hence preventing macsec XPN HW
> offload.
> 
> Fix by moving macsec XPN properties reading prior to HW offload path.
> 
> Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
> Reviewed-by: Raed Salem <raeds@...dia.com>
> Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Is there a driver in the tree which uses those values today?
I can't grep out any rx_sa->key accesses in the drivers at all :S

If there is none it's not really a fix.