linux-kernel - RE: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR12MB6353673BC6106F004B128267AB699@IA1PR12MB6353.namprd12.prod.outlook.com>
Date:   Sun, 14 Aug 2022 07:32:05 +0000
From:   Emeel Hakim <ehakim@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "edumazet@...gle.com" <edumazet@...gle.com>,
        "mayflowerera@...il.com" <mayflowerera@...il.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Raed Salem <raeds@...dia.com>
Subject: RE: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec
 offload



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, 11 August 2022 19:26
> To: Emeel Hakim <ehakim@...dia.com>
> Cc: edumazet@...gle.com; mayflowerera@...il.com; pabeni@...hat.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Raed Salem
> <raeds@...dia.com>
> Subject: Re: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec
> offload
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, 9 Aug 2022 13:29:05 +0300 Emeel Hakim wrote:
> > Currently macsec invokes HW offload path before reading extended
> > packet number (XPN) related user properties i.e. salt and short secure
> > channel identifier (ssci), hence preventing macsec XPN HW offload.
> >
> > Fix by moving macsec XPN properties reading prior to HW offload path.
> >
> > Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
> > Reviewed-by: Raed Salem <raeds@...dia.com>
> > Signed-off-by: Emeel Hakim <ehakim@...dia.com>
> 
> Is there a driver in the tree which uses those values today?
> I can't grep out any rx_sa->key accesses in the drivers at all :S
> 
> If there is none it's not really a fix.

Thanks for the review, agreed
will repost it with commit adjustment to net-next as part
of a macsec offload series.