linux-kernel - Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fe2bac3-1002-62d0-b016-ec0aab5136af@suse.com>
Date:   Fri, 12 Aug 2022 12:08:05 +0200
From:   Juergen Gross <jgross@...e.com>
To:     SeongJae Park <sj@...nel.org>, roger.pau@...rix.com
Cc:     axboe@...nel.dk, boris.ostrovsky@...cle.com, olekstysh@...il.com,
        andrii.chepurnyi82@...il.com, mheyne@...zon.de,
        xen-devel@...ts.xenproject.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in
 'feature_persistent'

On 16.07.22 00:51, SeongJae Park wrote:
> Introduction of 'feature_persistent' made two bugs.  First one is wrong
> overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong
> parameter value caching position, and the second one is unintended
> behavioral change that could break previous dynamic frontend/backend
> persistent feature support changes.  This patchset fixes the issues.
> 
> Changes from v3
> (https://lore.kernel.org/xen-devel/20220715175521.126649-1-sj@kernel.org/)
> - Split 'blkback' patch for each of the two issues
> - Add 'Reported-by: Andrii Chepurnyi <andrii.chepurnyi82@...il.com>'
> 
> Changes from v2
> (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/)
> - Keep the behavioral change of v1
> - Update blkfront's counterpart to follow the changed behavior
> - Update documents for the changed behavior
> 
> Changes from v1
> (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/)
> - Avoid the behavioral change
>    (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/)
> - Rebase on latest xen/tip/linux-next
> - Re-work by SeongJae Park <sj@...nel.org>
> - Cc stable@
> 
> Maximilian Heyne (1):
>    xen-blkback: Apply 'feature_persistent' parameter when connect
> 
> SeongJae Park (2):
>    xen-blkback: fix persistent grants negotiation
>    xen-blkfront: Apply 'feature_persistent' parameter when connect
> 
>   .../ABI/testing/sysfs-driver-xen-blkback      |  2 +-
>   .../ABI/testing/sysfs-driver-xen-blkfront     |  2 +-
>   drivers/block/xen-blkback/xenbus.c            | 20 ++++++++-----------
>   drivers/block/xen-blkfront.c                  |  4 +---
>   4 files changed, 11 insertions(+), 17 deletions(-)
> 

For the series:

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)