linux-kernel - Re: [PATCH v2] kernel/sys_ni: add compat entry for fadvise64_64

Open Source and information security mailing list archives

Message-ID: <7b97d66d-610a-6750-f17f-4de41a97b528@infradead.org>
Date:   Sat, 13 Aug 2022 10:44:42 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Conor.Dooley@...rochip.com, linux-kernel@...r.kernel.org
Cc:     arnd@...db.de, josh@...htriplett.org, paul.walmsley@...ive.com,
        palmer@...belt.com, aou@...s.berkeley.edu,
        linux-riscv@...ts.infradead.org, linux-api@...r.kernel.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org
Subject: Re: [PATCH v2] kernel/sys_ni: add compat entry for fadvise64_64

On 8/13/22 10:03, Conor.Dooley@...rochip.com wrote:
> On 07/08/2022 23:09, Randy Dunlap wrote:
>> When CONFIG_ADVISE_SYSCALLS is not set/enabled and CONFIG_COMPAT is
>> set/enabled, the riscv compat_syscall_table references
>> 'compat_sys_fadvise64_64', which is not defined:
>>
>> riscv64-linux-ld: arch/riscv/kernel/compat_syscall_table.o:(.rodata+0x6f8):
>> undefined reference to `compat_sys_fadvise64_64'
>>
>> Add 'fadvise64_64' to kernel/sys_ni.c as a conditional COMPAT function
>> so that when CONFIG_ADVISE_SYSCALLS is not set, there is a fallback
>> function available.
> 
> Is this in a 6.0 destined tree somewhere that I've missed?
> Bumped into it while looking at an unrelated LKP randconfig error.
> FWIW:
> Tested-by: Conor Dooley <conor.dooley@...rochip.com>
> Thanks,
> Conor.

It's in Andrew's mm-hotfixes-unstable branch AFAIK.

Thanks.

>>
>> Fixes: d3ac21cacc24 ("mm: Support compiling out madvise and fadvise")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Suggested-by: Arnd Bergmann <arnd@...db.de>
>> Cc: Josh Triplett <josh@...htriplett.org>
>> Cc: Paul Walmsley <paul.walmsley@...ive.com>
>> Cc: Palmer Dabbelt <palmer@...belt.com>
>> Cc: Albert Ou <aou@...s.berkeley.edu>
>> Cc: linux-riscv@...ts.infradead.org
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: linux-api@...r.kernel.org
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: linux-mm@...ck.org
>> ---
>> v2: patch kernel/sys_ni.c (for any arch) instead of arch/riscv's
>>     unistd.h (Arnd)
>>
>>  kernel/sys_ni.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/kernel/sys_ni.c
>> +++ b/kernel/sys_ni.c
>> @@ -277,6 +277,7 @@ COND_SYSCALL(landlock_restrict_self);
>>  
>>  /* mm/fadvise.c */
>>  COND_SYSCALL(fadvise64_64);
>> +COND_SYSCALL_COMPAT(fadvise64_64);
>>  
>>  /* mm/, CONFIG_MMU only */
>>  COND_SYSCALL(swapon);
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv

-- 
~Randy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives