lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Aug 2022 15:12:28 +0200 From: Peter Geis <pgwipeout@...il.com> To: Jarrah Gosbell <kernel@...ef.tools> Cc: Jacob Chen <jacob-chen@...wrt.com>, Ezequiel Garcia <ezequiel@...guardiasur.com.ar>, Mauro Carvalho Chehab <mchehab@...nel.org>, Heiko Stuebner <heiko@...ech.de>, Linux Media Mailing List <linux-media@...r.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>, arm-mail-list <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, phone-devel@...r.kernel.org, Ondrej Jirman <megi@....cz> Subject: Re: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs On Sun, Aug 14, 2022 at 6:10 AM Jarrah Gosbell <kernel@...ef.tools> wrote: > > From: Ondrej Jirman <megi@....cz> > > rga_parse_dt is missing a error return, so if some of the resources > return DEFER_PROBE, probe will succeed without these resources. > > Signed-off-by: Ondrej Jirman <megi@....cz> > Signed-off-by: Jarrah Gosbell <kernel@...ef.tools> > --- > drivers/media/platform/rockchip/rga/rga.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index 2f8df74ad0fd..b88dd7ed2036 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -815,8 +815,10 @@ static int rga_probe(struct platform_device *pdev) > mutex_init(&rga->mutex); > > ret = rga_parse_dt(rga); > - if (ret) > + if (ret) { > dev_err(&pdev->dev, "Unable to parse OF data\n"); If this can return EPROBE_DEFER, shouldn't this be dev_err_probe instead of dev_err? > + return ret; > + } > > pm_runtime_enable(rga->dev); > > -- > 2.35.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Powered by blists - more mailing lists