linux-kernel - Re: [PATCH] media: rockchip: rga: Fix probe rga_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <821647de-be45-557a-e1eb-2e70e186f2d8@undef.tools>
Date:   Mon, 15 Aug 2022 08:01:52 +1000
From:   Jarrah Gosbell <kernel@...ef.tools>
To:     Peter Geis <pgwipeout@...il.com>
Cc:     Jacob Chen <jacob-chen@...wrt.com>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        arm-mail-list <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        phone-devel@...r.kernel.org, Ondrej Jirman <megi@....cz>
Subject: Re: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs


On 8/14/22 23:12, Peter Geis wrote:
>>          ret = rga_parse_dt(rga);
>> -       if (ret)
>> +       if (ret) {
>>                  dev_err(&pdev->dev, "Unable to parse OF data\n");
> If this can return EPROBE_DEFER, shouldn't this be dev_err_probe
> instead of dev_err?


Looking into it that does make more sense. I suspect it wasn't done this 
way originally because dev_err_probe isn't used elsewhere in rga.c. I'll 
send a v2 with that change shortly.


Thanks for the review.