linux-kernel - Re: [PATCH] PCI: endpoint: fix Kconfig indent style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANXvt5osmx+iFdVXYQhGcdBiz5VsA60jzdKXg42c_zSDuxoHxg@mail.gmail.com>
Date:   Mon, 15 Aug 2022 12:00:23 +0900
From:   Shunsuke Mie <mie@...l.co.jp>
To:     Jon Mason <jdmason@...zu.us>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Frank Li <Frank.Li@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Ren Zhijie <renzhijie2@...wei.com>, linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: endpoint: fix Kconfig indent style

I have a question, not related to the patch. Could you please tell me
why the ntb related patches are managed outside the pci branch,
Helgaas's branch? It confused me a little to find the ntb branch.

Thanks,
Shunsuke

2022年8月15日(月) 11:50 Shunsuke Mie <mie@...l.co.jp>:
>
> Change to follow the Kconfig style guide. This patch fixes to use tab
> rather than space to indent, while help text is indented an additional
> two spaces.
>
> Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP")
> Signed-off-by: Shunsuke Mie <mie@...l.co.jp>
> ---
>  drivers/pci/endpoint/functions/Kconfig | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig
> index 295a033ee9a2..9fd560886871 100644
> --- a/drivers/pci/endpoint/functions/Kconfig
> +++ b/drivers/pci/endpoint/functions/Kconfig
> @@ -27,13 +27,13 @@ config PCI_EPF_NTB
>           If in doubt, say "N" to disable Endpoint NTB driver.
>
>  config PCI_EPF_VNTB
> -        tristate "PCI Endpoint NTB driver"
> -        depends on PCI_ENDPOINT
> -        depends on NTB
> -        select CONFIGFS_FS
> -        help
> -          Select this configuration option to enable the Non-Transparent
> -          Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
> -          between PCI Root Port and PCIe Endpoint.
> +       tristate "PCI Endpoint NTB driver"
> +       depends on PCI_ENDPOINT
> +       depends on NTB
> +       select CONFIGFS_FS
> +       help
> +         Select this configuration option to enable the Non-Transparent
> +         Bridge (NTB) driver for PCIe Endpoint. NTB driver implements NTB
> +         between PCI Root Port and PCIe Endpoint.
>
> -          If in doubt, say "N" to disable Endpoint NTB driver.
> +         If in doubt, say "N" to disable Endpoint NTB driver.
> --
> 2.17.1
>