linux-kernel - Re: [PATCH v5 4/7] platform/chrome: cros_typec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvsnE55zGVGxGpPv@google.com>
Date:   Tue, 16 Aug 2022 05:11:47 +0000
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
        bleung@...omium.org, Daisuke Nojiri <dnojiri@...omium.org>,
        "Dustin L. Howett" <dustin@...ett.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <groeck@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Xiang wangx <wangxiang@...rlc.com>
Subject: Re: [PATCH v5 4/7] platform/chrome: cros_typec_switch: Add event
 check

On Mon, Aug 15, 2022 at 06:34:24AM +0000, Prashant Malani wrote:
> The Chrome EC updates Type-C status events when mux set requests from

To be consistent to the series, I guess you would like to use ChromeOS
instead of Chrome?

> +static int cros_typec_send_clear_event(struct cros_typec_switch_data *sdata, int port_num,
> +				       u32 events_mask)
> +{
[...]
> +	return cros_ec_cmd(sdata->ec, 0, EC_CMD_TYPEC_CONTROL, &req,
> +			   sizeof(req), NULL, 0);

The line can join to the previous line without exceeding col-100.