linux-kernel - Re: [PATCH v5 7/7] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvsnY6LwVZFibj7x@google.com>
Date:   Tue, 16 Aug 2022 05:13:07 +0000
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
        bleung@...omium.org, Daisuke Nojiri <dnojiri@...omium.org>,
        "Dustin L. Howett" <dustin@...ett.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Guenter Roeck <groeck@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Tinghan Shen <tinghan.shen@...iatek.com>,
        Xiang wangx <wangxiang@...rlc.com>
Subject: Re: [PATCH v5 7/7] platform/chrome: cros_ec_typec: Get retimer handle

On Mon, Aug 15, 2022 at 06:34:30AM +0000, Prashant Malani wrote:
> Where available, obtain the handle to retimer switch specified via
> firmware, and update the mux configuration callsites to add retimer
> support for supported modes.
> 
> Signed-off-by: Prashant Malani <pmalani@...omium.org>

With a nit,
Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>

> +static int cros_typec_retimer_set(struct typec_retimer  *retimer, struct typec_mux_state state)

nit: double spaces.