linux-kernel - Re: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14bed619e6a884f37403ec58aead34ff86525f26.camel@ljones.dev>
Date:   Tue, 16 Aug 2022 18:23:13 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     markgross@...nel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable
 method")

On Mon, 2022-08-15 at 15:40 +0200, Hans de Goede wrote:
> Hi,
> 
> On 8/15/22 15:25, Hans de Goede wrote:
> > Hi Luke,
> > 
> > On 8/13/22 00:25, Luke D. Jones wrote:
> > > The dgpu_disable attribute was not documented, this adds the
> > > required documentation.
> > > 
> > > Signed-off-by: Luke D. Jones <luke@...nes.dev>
> > 
> > Thanks for the patch. Note that the Fixes tag should be above your
> > signed-off-by and then the patch should otherwise have a normal
> > subject + body. I've changed the commit msg to the following
> > while merging this:
> > 
> > """
> > platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute
> >     
> > The dgpu_disable attribute was not documented, this adds the
> > required documentation.
> >     
> > Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
> > Signed-off-by: Luke D. Jones <luke@...nes.dev>
> > """
> 
> While merging this I noticed that this is also using spaces
> instead of tabs for indentation, where as the rest of
> the file is using tabs.
> 
> I've also fixed this up while merging, but next time
> please make sure to use spaces.
> 
> I will make similar spaces -> tabs changes to patch 2/6 and 3/6
> 

I ran these through ./scripts/checkpatch.pl... I'm really not sure what
happened. I'll triple-check that in future.

> Regards,
> 
> Hans
> 
> 
> 
> 
> > > ---
> > >  Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++
> > >  1 file changed, 9 insertions(+)
> > > 
> > > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > index 04885738cf15..0f932fd60f4a 100644
> > > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > @@ -57,3 +57,12 @@ Description:
> > >                         * 0 - default,
> > >                         * 1 - overboost,
> > >                         * 2 - silent
> > > +
> > > +What:          /sys/devices/platform/<platform>/dgpu_disable
> > > +Date:          Aug 2022
> > > +KernelVersion: 5.17
> > > +Contact:       "Luke Jones" <luke@...nes.dev>
> > > +Description:
> > > +               Disable discrete GPU:
> > > +                       * 0 - Enable dGPU,
> > > +                       * 1 - Disable dGPU,
> > > \ No newline at end of file
> > 
> > Next time please make sure the file always ends with a newline
> > even in intermediate patches.
> > 
> > Regards,
> > 
> > Hans
> > 
> > 
>