linux-kernel - Re: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <449cf9505daeb7b49deb199c101eb7b94e518ea7.camel@ljones.dev>
Date:   Tue, 16 Aug 2022 18:21:10 +1200
From:   Luke Jones <luke@...nes.dev>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     markgross@...nel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable
 method")

> Thanks for the patch. Note that the Fixes tag should be above your
> signed-off-by and then the patch should otherwise have a normal
> subject + body. I've changed the commit msg to the following
> while merging this:
> 
> """
> platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute
>     
> The dgpu_disable attribute was not documented, this adds the
> required documentation.
>     
> Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
> Signed-off-by: Luke D. Jones <luke@...nes.dev>
> """
> 
> and I will make similar changes to patch 2/6 and 3/6
> 

Ah thank you, sorry about that, I thought I got it correct Perhaps I
didn't read
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#describe-changes
well enough.

> > ---
> >  Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > index 04885738cf15..0f932fd60f4a 100644
> > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > @@ -57,3 +57,12 @@ Description:
> >                         * 0 - default,
> >                         * 1 - overboost,
> >                         * 2 - silent
> > +
> > +What:          /sys/devices/platform/<platform>/dgpu_disable
> > +Date:          Aug 2022
> > +KernelVersion: 5.17
> > +Contact:       "Luke Jones" <luke@...nes.dev>
> > +Description:
> > +               Disable discrete GPU:
> > +                       * 0 - Enable dGPU,
> > +                       * 1 - Disable dGPU,
> > \ No newline at end of file
> 
> Next time please make sure the file always ends with a newline
> even in intermediate patches.
> 
> Regards,
> 
> Hans
> 
>