linux-kernel - Re: [PATCH 5.15 154/779] netfilter: nf_tables: add rescheduling points during loop detection walks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YvtgRU9pjwNdX8ih@kroah.com>
Date:   Tue, 16 Aug 2022 11:15:49 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Florian Westphal <fw@...len.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 154/779] netfilter: nf_tables: add rescheduling
 points during loop detection walks

On Mon, Aug 15, 2022 at 08:58:22PM +0200, Florian Westphal wrote:
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > From: Florian Westphal <fw@...len.de>
> > 
> > [ Upstream commit 81ea010667417ef3f218dfd99b69769fe66c2b67 ]
> > 
> > Add explicit rescheduling points during ruleset walk.
> 
> NAK.  There is a partial revert pending.
> 
> > @@ -9225,9 +9227,13 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx,
> >  				break;
> >  			}
> >  		}
> > +
> > +		cond_resched();
> >  	}
> >  
> >  	list_for_each_entry(set, &ctx->table->sets, list) {
> > +		cond_resched();
> 
> Can't be used here, this can be called from atomic context.

Thanks, now dropped from all branches.

greg k-h