linux-kernel - Re: [PATCH v8 053/103] KVM: TDX: TDP MMU TDX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31fec1b4438a6d9bb7ff719f96caa8b23ed764d6.camel@intel.com>
Date:   Tue, 16 Aug 2022 23:04:34 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "Christopherson,, Sean" <seanjc@...gle.com>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Shahar, Sagi" <sagis@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "isaku.yamahata@...il.com" <isaku.yamahata@...il.com>,
        "Aktas, Erdem" <erdemaktas@...gle.com>
Subject: Re: [PATCH v8 053/103] KVM: TDX: TDP MMU TDX support

On Tue, 2022-08-16 at 15:35 +0000, Sean Christopherson wrote:
> On Sun, Aug 07, 2022, isaku.yamahata@...el.com wrote:
> > +static void tdx_unpin_pfn(struct kvm *kvm, kvm_pfn_t pfn)
> 
> Why does this helper exist?  KVM should not be pinning private pages, that should
> be the purview of the private backing fd.

Agreed.  Similar comment made to v7 as well:

https://lore.kernel.org/all/20220811182942.GD504743@ls.amr.corp.intel.com/t/#m995b4255e0b5a0759c31e4f4cf7be40cdf5ee1a4

-- 
Thanks,
-Kai