linux-kernel - Re: [PATCH] KVM: s390: pci: VFIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7a094e9-7c36-a21d-8f7a-82a8b94f8044@linux.ibm.com>
Date:   Wed, 17 Aug 2022 09:10:15 +0200
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     Matthew Rosato <mjrosato@...ux.ibm.com>
Cc:     rdunlap@...radead.org, linux-kernel@...r.kernel.org, lkp@...el.com,
        borntraeger@...ux.ibm.com, farman@...ux.ibm.com,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: s390: pci: VFIO_PCI ZDEV configuration fix



On 8/17/22 00:15, Matthew Rosato wrote:
> On 8/16/22 4:28 PM, Pierre Morel wrote:
>> Fixing configuration for VFIO PCI interpretation.
>>

> 4)
> CONFIG_KVM=m
> CONFIG_VFIO_PCI_CORE=y
> CONFIG_VFIO_PCI=y
> CONFIG_VFIO_PCI_ZDEV_KVM=m
> 
> fails with:
> 
> ld: drivers/vfio/pci/vfio_pci_core.o: in function `vfio_pci_core_enable':
> /usr/src/linux/drivers/vfio/pci/vfio_pci_core.c:320: undefined reference to `vfio_pci_zdev_open_device'
> ld: /usr/src/linux/drivers/vfio/pci/vfio_pci_core.c:349: undefined reference to `vfio_pci_zdev_close_device'
> ld: drivers/vfio/pci/vfio_pci_core.o: in function `vfio_pci_core_disable':
> /usr/src/linux/drivers/vfio/pci/vfio_pci_core.c:428: undefined reference to `vfio_pci_zdev_close_device'
> ld: drivers/vfio/pci/vfio_pci_core.o: in function `vfio_pci_core_ioctl':
> /usr/src/linux/drivers/vfio/pci/vfio_pci_core.c:712: undefined reference to `vfio_pci_info_zdev_add_caps'
> 
> 
> 5)
> CONFIG_KVM=m
> CONFIG_VFIO_PCI_CORE=y
> CONFIG_VFIO_PCI=y
> CONFIG_VFIO_PCI_ZDEV_KVM=y
> 
> This forces CONFIG_VFIO_PCI_ZDEV_KVM to 'm' and fails as above.
> 
> 
> 

yes right
I was really too stupid yesterday
I think you are right and you should go as you proposed or use some 
pointer hook inside S390 to register with KVM.

-- 
Pierre Morel
IBM Lab Boeblingen