linux-kernel - Re: [PATCH v3 3/3] Input: joystick: xpad: Add X-Box Adaptive Controller XBox button

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a521e4f327778e390f344da16c9df0b6dea82fb.camel@hadess.net>
Date:   Wed, 17 Aug 2022 12:37:34 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Nate Yocom <nate@...om.org>, dmitry.torokhov@...il.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] Input: joystick: xpad: Add X-Box Adaptive
 Controller XBox button

On Sat, 2022-08-13 at 11:53 -0700, Nate Yocom wrote:
> Adaptive controller sets 0x02 bit for this button, all others set
> 0x01
> so presence of either is used for BTN_MODE.
> 
> Signed-off-by: Nate Yocom <nate@...om.org>

Tested-by: Bastien Nocera <hadess@...ess.net>

> ---
>  drivers/input/joystick/xpad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/joystick/xpad.c
> b/drivers/input/joystick/xpad.c
> index 83a4f4d07af5..bea71721b6cd 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -859,7 +859,7 @@ static void xpadone_process_packet(struct
> usb_xpad *xpad, u16 cmd, unsigned char
>                 if (data[1] == 0x30)
>                         xpadone_ack_mode_report(xpad, data[2]);
>  
> -               input_report_key(dev, BTN_MODE, data[4] & 0x01);
> +               input_report_key(dev, BTN_MODE, data[4] & 0x03);
>                 input_sync(dev);
>                 return;
>         }