linux-kernel - Re: [PATCH v2 1/4] Make place for common balloon code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e692b61d-7760-48bd-b22a-9ffa9162b4f7@virtuozzo.com>
Date:   Thu, 18 Aug 2022 09:43:29 +0300
From:   Alexander Atanasov <alexander.atanasov@...tuozzo.com>
To:     Ritesh Harjani <ritesh.list@...il.com>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Nadav Amit <namit@...are.com>,
        VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>, kernel@...nvz.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        virtualization@...ts.linux-foundation.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/4] Make place for common balloon code

Hello,

On 18.08.22 7:41, Ritesh Harjani wrote:
> On 22/08/16 12:41PM, Alexander Atanasov wrote:
>> File already contains code that is common along balloon
>> drivers so rename it to reflect its contents.
>> mm/balloon_compaction.c -> mm/balloon_common.c
>>
>> Signed-off-by: Alexander Atanasov <alexander.atanasov@...tuozzo.com>
>> ---
>>   MAINTAINERS                                              | 4 ++--
>>   arch/powerpc/platforms/pseries/cmm.c                     | 2 +-
>>   drivers/misc/vmw_balloon.c                               | 2 +-
>>   drivers/virtio/virtio_balloon.c                          | 2 +-
>>   include/linux/{balloon_compaction.h => balloon_common.h} | 2 +-
>>   mm/Makefile                                              | 2 +-
>>   mm/{balloon_compaction.c => balloon_common.c}            | 4 ++--
> 
>>   mm/migrate.c                                             | 2 +-
>>   mm/vmscan.c                                              | 2 +-
> I think we don't need balloon headers in above two files at all.
> I don't see any references of balloon functions in them.

...

> Since I don't often look into this side of code, it's better to confirm :)

Yes, you are right. It passed a visual and compile verification.
I will remove them in the next iteration. Thanks for pointing it out :)

-- 
Regards,
Alexander Atanasov