[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220818084430.0ca10b30@smeagol>
Date: Thu, 18 Aug 2022 08:44:30 +0200
From: Juerg Haefliger <juerg.haefliger@...onical.com>
To: Neil Armstrong <narmstrong@...libre.com>
Cc: mchehab@...nel.org, gregkh@...uxfoundation.org,
khilman@...libre.com, jbrunet@...libre.com,
martin.blumenstingl@...glemail.com,
linux-amlogic@...ts.infradead.org, linux-staging@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
On Wed, 17 Aug 2022 18:08:19 +0200
Neil Armstrong <narmstrong@...libre.com> wrote:
> On 17/08/2022 16:05, Juerg Haefliger wrote:
> > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> > provide that information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@...onical.com>
> > ---
> > .../staging/media/meson/vdec/vdec_platform.c | 20 +++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> > index 88c9d72e1c83..c7750d4be848 100644
> > --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
> > .num_formats = ARRAY_SIZE(vdec_formats_sm1),
> > .revision = VDEC_REVISION_SM1,
> > };
> > +
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
>
> Duplicate
Oh this is embarrassing :-(
> > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
>
> DDDDDDDuplicate
>
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
>
> Duplicate
>
> > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
>
> With the duplicate entries removed, please add my:
> Reviewed-by: Neil Armstrong <narmstrong@...libre.com>
Will do. Thanks for the review.
...Juerg
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists