linux-kernel - Re: [RFT PATCH v2 14/14] arm64: dts: qcom: sm8150: switch TCSR mutex to MMIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 14:00:50 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH v2 14/14] arm64: dts: qcom: sm8150: switch TCSR mutex
 to MMIO



On 18.08.2022 09:04, Krzysztof Kozlowski wrote:
> On 18/08/2022 00:07, Konrad Dybcio wrote:
>>
>>
>> On 17.08.2022 15:03, Krzysztof Kozlowski wrote:
>>> The TCSR mutex bindings allow device to be described only with address
>>> space (so it uses MMIO, not syscon regmap).  This seems reasonable as
>>> TCSR mutex is actually a dedicated IO address space and it also fixes DT
>>> schema checks:
>>>
>>>   qcom/sm8150-mtp.dtb: hwlock: 'reg' is a required property
>>>   qcom/sm8150-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 13 ++++---------
>>>  1 file changed, 4 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>>> index 7d509ecd44da..dc6770391813 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>>> @@ -585,12 +585,6 @@ scm: scm {
>>>  		};
>>>  	};
>>>  
>>> -	tcsr_mutex: hwlock {
>>> -		compatible = "qcom,tcsr-mutex";
>>> -		syscon = <&tcsr_mutex_regs 0 0x1000>;
>>> -		#hwlock-cells = <1>;
>>> -	};
>>> -
>>>  	memory@...00000 {
>>>  		device_type = "memory";
>>>  		/* We expect the bootloader to fill in the size */
>>> @@ -2054,9 +2048,10 @@ ipa_virt: interconnect@...0000 {
>>>  			qcom,bcm-voters = <&apps_bcm_voter>;
>>>  		};
>>>  
>>> -		tcsr_mutex_regs: syscon@...0000 {
>>> -			compatible = "syscon";
>>> -			reg = <0x0 0x01f40000 0x0 0x40000>;
>>> +		tcsr_mutex: hwlock@...0000 {
>>> +			compatible = "qcom,tcsr-mutex";
>>> +			reg = <0 0x01f40000 0 0x20000>;
>>> +			#hwlock-cells = <1>;
>>>  		};
>> No replacement for the trailing 0x20000?
>>
> 
> There is no user of it, so I did not add. I could add remaining block
> just for completeness.

Please do, maybe even in a separate patch so as not to resend the entire
series needlessly.

Konrad
> 
> 
> Best regards,
> Krzysztof