linux-kernel - Re: checkpatch.pl bug for EXPORT_SYMBOL when struct initialization follows define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yv5Spab6mC0U5w/v@spruce>
Date:   Thu, 18 Aug 2022 10:54:29 -0400
From:   Joe Simmons-Talbott <joetalbott@...il.com>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: checkpatch.pl bug for EXPORT_SYMBOL when struct initialization
 follows define

On Tue, Jun 28, 2022 at 06:10:41PM -0400, Joe Simmons-Talbott wrote:
> I believe I've found a bug in checkpatch.pl where an EXPORT_SYMBOL for
> an initialized struct following a simple #define without an intervening
> blank line falsely reports that EXPORT_SYMBOL doesn't follow the symbol
> definition.  Here's an example:
> 
> 	#define SOMETHING_ELSE 1
> 	struct blah foo = {
> 		.a = 1
> 	};
> 	EXPORT_SYMBOL(foo);
> 
> You can see from the debug print that the full statement has not been
> identified.
> 
> 	FOO A<+EXPORT_SYMBOL(foo);> stat<+      .a = 1
> 	 };> name<foo>
> 
> Unfortunately my perl skills were not sufficient to find a fix.

I created the following BZ https://bugzilla.kernel.org/show_bug.cgi?id=216374

Thanks,
Joe