lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2022 09:03:21 -0700 From: Kees Cook <keescook@...omium.org> To: Konstantin Shelekhin <k.shelekhin@...ro.com> Cc: ojeda@...nel.org, boqun.feng@...il.com, gregkh@...uxfoundation.org, jarkko@...nel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, patches@...ts.linux.dev, rust-for-linux@...r.kernel.org, torvalds@...ux-foundation.org Subject: Re: [PATCH v9 01/27] kallsyms: use `sizeof` instead of hardcoded size On Thu, Aug 18, 2022 at 12:03:37PM +0300, Konstantin Shelekhin wrote: > On Wed, Aug 17, 2022 at 12:36:33PM -0700, Kees Cook wrote: > > On Sat, Aug 06, 2022 at 01:40:33AM +0300, Konstantin Shelekhin wrote: > > > > diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c > > > > index f18e6dfc68c5..52f5488c61bc 100644 > > > > --- a/scripts/kallsyms.c > > > > +++ b/scripts/kallsyms.c > > > > @@ -206,7 +206,7 @@ static struct sym_entry *read_symbol(FILE *in) > > > > > > > > rc = fscanf(in, "%llx %c %499s\n", &addr, &type, name); > > > > if (rc != 3) { > > > > - if (rc != EOF && fgets(name, 500, in) == NULL) > > > > + if (rc != EOF && fgets(name, sizeof(name), in) == NULL) > > > > fprintf(stderr, "Read error or end of file.\n"); > > > > return NULL; > > > > } > > > > > > Might be another nit, but IMO it's better to use ARRAY_SIZE() here. > > > > I'm not sure I see a benefit for char arrays. It'll produce the same > > result, and the tradition for string functions is to use sizeof(). > > *shrug* > > ARRAY_SIZE() (though not this one) can catch this: > > - char array[16]; > + char *array; > > Saves me some. Oh, that's an excellent point; I forgot it'll actually compile-time error if the var is a pointer. +1 -- Kees Cook
Powered by blists - more mailing lists