linux-kernel - Re: [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220819155242.w32vcwobt4ucvpyv@liuwe-devbox-debian-v2>
Date:   Fri, 19 Aug 2022 15:52:42 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Dexuan Cui <decui@...rosoft.com>, quic_jhugo@...cinc.com,
        wei.liu@...nel.org, kys@...rosoft.com, haiyangz@...rosoft.com,
        sthemmin@...rosoft.com, lpieralisi@...nel.org, bhelgaas@...gle.com,
        linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, mikelley@...rosoft.com,
        robh@...nel.org, kw@...ux.com, alex.williamson@...hat.com,
        boqun.feng@...il.com, Boqun.Feng@...rosoft.com,
        Carl Vanderlip <quic_carlv@...cinc.com>
Subject: Re: [PATCH] PCI: hv: Fix the definiton of vector in
 hv_compose_msi_msg()

On Mon, Aug 15, 2022 at 03:35:45PM -0500, Bjorn Helgaas wrote:
> s/definiton/definition/ in subject
> (only if you have other occasion to repost this)
> 
> On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote:
> > The local variable 'vector' must be u32 rather than u8: see the
> > struct hv_msi_desc3.
> > 
> > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > hv_msi_desc2 and hv_msi_desc3.
> > 
> > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> > Cc: Jeffrey Hugo <quic_jhugo@...cinc.com>
> > Cc: Carl Vanderlip <quic_carlv@...cinc.com>
> 
> Looks like Wei has been applying most changes to pci-hyperv.c, so I
> assume the same will happen here.

I can take care of this one via hyperv-fixes, but ...

> 
> > ---
> > 
> > The patch should be appplied after the earlier patch:
> >     [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
> >     https://lwn.net/ml/linux-kernel/20220804025104.15673-1-decui%40microsoft.com/
> > 

... this patch looks to be rejected.

Thanks,
Wei.