linux-kernel - RE: [PATCH] PCI: hv: Fix the definiton of vector in hv_compose_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SA1PR21MB13353BD0E507FEF441B99FE4BF6C9@SA1PR21MB1335.namprd21.prod.outlook.com>
Date:   Fri, 19 Aug 2022 15:57:19 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Wei Liu <wei.liu@...nel.org>, Bjorn Helgaas <helgaas@...nel.org>
CC:     "quic_jhugo@...cinc.com" <quic_jhugo@...cinc.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>,
        "robh@...nel.org" <robh@...nel.org>, "kw@...ux.com" <kw@...ux.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "boqun.feng@...il.com" <boqun.feng@...il.com>,
        Boqun Feng <Boqun.Feng@...rosoft.com>,
        Carl Vanderlip <quic_carlv@...cinc.com>
Subject: RE: [PATCH] PCI: hv: Fix the definiton of vector in
 hv_compose_msi_msg()

> From: Wei Liu <wei.liu@...nel.org>
> Sent: Friday, August 19, 2022 8:53 AM
> To: Bjorn Helgaas <helgaas@...nel.org>
> 
> On Mon, Aug 15, 2022 at 03:35:45PM -0500, Bjorn Helgaas wrote:
> > s/definiton/definition/ in subject
> > (only if you have other occasion to repost this)
> >
> > On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote:
> > > The local variable 'vector' must be u32 rather than u8: see the
> > > struct hv_msi_desc3.
> > >
> > > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > > hv_msi_desc2 and hv_msi_desc3.
> > >
> > > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > > Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> > > Cc: Jeffrey Hugo <quic_jhugo@...cinc.com>
> > > Cc: Carl Vanderlip <quic_carlv@...cinc.com>
> >
> > Looks like Wei has been applying most changes to pci-hyperv.c, so I
> > assume the same will happen here.
> 
> I can take care of this one via hyperv-fixes, but ...

Wei, please ignore this patch. I'll post v2 of this patch with v2 of the other patch.

> > > ---
> > >
> > > The patch should be appplied after the earlier patch:
> > >     [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
> > >
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flwn.ne
> t%2Fml%2Flinux-kernel%2F20220804025104.15673-1-decui%2540microsoft.co
> m%2F&amp;data=05%7C01%7Cdecui%40microsoft.com%7Cc8ab6638b7d747b
> cddf008da81fadc12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
> 37965211688628404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&
> amp;sdata=Rb2MfkSFmJ%2B8ze%2FllN0THBhODCtmnZ8oSMB0EOn20u4%3D&
> amp;reserved=0
> > >
> 
> ... this patch looks to be rejected.

Correct. I'm working on a new version.

> 
> Thanks,
> Wei.