linux-kernel - Re: [PATCH v2] driver core: Fix bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yv/MKymRC9O04Nqu@google.com>
Date:   Fri, 19 Aug 2022 10:45:15 -0700
From:   Isaac Manjarres <isaacmanjarres@...gle.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Bart Van Assche <bvanassche@....org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Russell King <rmk+kernel@....linux.org.uk>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Saravana Kannan <saravanak@...gle.com>, stable@...nel.org,
        kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] driver core: Fix bus_type.match() error handling

On Fri, Aug 19, 2022 at 04:28:32AM -0700, Guenter Roeck wrote:
> On Thu, Aug 18, 2022 at 05:38:15PM -0700, Isaac Manjarres wrote:
> > On Thu, Aug 18, 2022 at 03:59:32PM -0700, Guenter Roeck wrote:
> > > Requesting system reboot
> > > sd 0:0:0:0: [sda] Synchronizing SCSI cache
> > > ci_hdrc ci_hdrc.1: remove, state 4
> > > usb usb2: USB disconnect, device number 1
> > > ci_hdrc ci_hdrc.1: USB bus 2 deregistered
> > > ci_hdrc ci_hdrc.0: remove, state 1
> > > usb usb1: USB disconnect, device number 1
> > > usb 1-1: USB disconnect, device number 2
> > > sd 0:0:0:0: [sda] Synchronizing SCSI cache
> > > sd 0:0:0:0: [sda] Synchronize Cache(10) failed: Result: hostbyte=0x01 driverbyte=DRIVER_OK
> > > 
> > > [ stuck here until qemu is killed ]
> > > 
> > Hi Guenter,
> > 
> > I'm actually observing the behavior described above even without my patch.
> > The tip of my tree is currently at 573ae4f13f63 ("tee: add overflow check in
> > register_shm_helper()"). I used git bisect to find what commit was
> > causing the problem, and narrowed it down to this series[1].
> > 
> > I reverted all 4 patches in that series, and I no longer see this hang
> > with my tree.
> > 
> > [1]: https://lore.kernel.org/all/20220712221936.1199196-1-bvanassche@acm.org/
> > 
> > Are these patches part of the tree you're using for testing and
> > observing this hang in?
> > 
> 
> Yes, you are correct. I also see the problem in the mainline kernel,
> at SHA 3b06a2755758, and with a large number of boots from usb drive
> in various arm emulations. Sorry for the confusion. Too many crashes :-(.
> 
> Guenter

No worries, thanks for confirming.

Hi Bart,

It seems that the patches mentioned in [1] are causing a hang during
reboot for various ARM emulations when booting from USB. Can you please
take a look? There's more information about what defconfig, rootfs, and
qemu commandline to use at [2].

[1]: https://lore.kernel.org/all/20220712221936.1199196-1-bvanassche@acm.org/
[2]: https://lore.kernel.org/all/20220818225932.GA3433999@roeck-us.net/

Thanks,
Isaac