linux-kernel - Re: [PATCH] mm: hugetlb: simplify per-node sysfs creation and removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A0353CE2-D014-4B35-95F1-40345D1B66E6@linux.dev>
Date:   Fri, 19 Aug 2022 14:44:13 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Muchun Song <songmuchun@...edance.com>, rafael@...nel.org,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Oscar Salvador <osalvador@...e.de>,
        David Hildenbrand <david@...hat.com>,
        linux-kernel@...r.kernel.org, Linux MM <linux-mm@...ck.org>,
        lee.schermerhorn@...com
Subject: Re: [PATCH] mm: hugetlb: simplify per-node sysfs creation and removal



> On Aug 19, 2022, at 14:32, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> On Fri, Aug 19, 2022 at 01:21:37PM +0800, Muchun Song wrote:
>> The following commit offload per-node sysfs creation and removal to a kworker and
>> did not say why it is needed.  And it also said "I don't know that this is
>> absolutely required".  It seems like the author was not sure as well.  Since it
>> only complicates the code, this patch will revert the changes to simplify the code.
>> 
>>  39da08cb074c ("hugetlb: offload per node attribute registrations")
> 
> Any specific reason why you did not cc: the original author of this
> commit, or anyone else on the patch?

OK. Cc Lee Schermerhorn.

> 
>> We could use memory hotplug notifier to do per-node sysfs creation and removal
>> instead of inserting those operations to node registration and unregistration.
>> Then, it can reduce the code coupling between node.c and hugetlb.c.  Also, it can
>> simplify the code.
> 
> I do not think we had memory hotplug notifier back in 2009 when this
> commit was first written.

Maybe not. Commit 39da08cb074c is merger in 2009. However, hotplug notifier mechanism
is merged in 2006. The document is updated in 2007 (see commit 10020ca246c5).

> 
> How did you test this?  Did you use a HUGETLBFS system and verify that
> everything still works properly?  You are deleting a lot of code (always
> nice), but making sure everything is still operating the same is a good
> thing.

I really did the test (through a VM), it works properly.

Thanks.

> 
> thanks,
> 
> greg k-h