linux-kernel - [PATCH] gpio/rockchip: handle irq before toggle trigger for edge type irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220819014126.1235390-1-jay.xu@rock-chips.com>
Date:   Fri, 19 Aug 2022 09:41:26 +0800
From:   Jianqun Xu <jay.xu@...k-chips.com>
To:     heiko@...ech.de
Cc:     linus.walleij@...aro.org, jeffy.chen@...k-chips.com,
        linux-gpio@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Jianqun Xu <jay.xu@...k-chips.com>
Subject: [PATCH] gpio/rockchip: handle irq before toggle trigger for edge type irq

The irq demux for rockchip gpio interrupts do real irq handle after loop
over the bits from int status register. Some oldder SoCs such as RK3308
has no both edge trigger type support, replaced by a soft both type
which switch trigger type once a level type triggered.

For example, a irq is set to a IRQ_TYPE_EDGE_BOTH trigger type, but the
SoC not support really both edge trigger type, use a
IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING instead.

        --------
    ____|      |______

        ^      ^
	|      |
	|      [0] the falling edge come before irq ack set by driver !
	|
        rockchip_irq_demux set to EDGE_FALLING type
	rockchip_irq_demux call generic_handle_irq
	                          -> handle_edge_irq
				    -> irq_gc_ack_set_bit

The [0] irq will lost by software on board test.

With this patch, the generic_handle_irq has been move ahead before
trigger toggle to fix the [0] lost issue.

Signed-off-by: Jianqun Xu <jay.xu@...k-chips.com>
---
 drivers/gpio/gpio-rockchip.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index f91e876fd969..952d628a6f7e 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -346,6 +346,7 @@ static void rockchip_irq_demux(struct irq_desc *desc)
 		}
 
 		dev_dbg(bank->dev, "handling irq %d\n", irq);
+		generic_handle_irq(virq);
 
 		/*
 		 * Triggering IRQ on both rising and falling edge
@@ -377,8 +378,6 @@ static void rockchip_irq_demux(struct irq_desc *desc)
 						     bank->gpio_regs->ext_port);
 			} while ((data & BIT(irq)) != (data_old & BIT(irq)));
 		}
-
-		generic_handle_irq(virq);
 	}
 
 	chained_irq_exit(chip, desc);
-- 
2.25.1