linux-kernel - [steev:sc8280xp-next-20220818 132/159] drivers/soc/qcom/pmic_glink_altmode.c:234:16: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2022 09:45:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Steev Klimaszewski <steev@...i.org>
Subject: [steev:sc8280xp-next-20220818 132/159]
 drivers/soc/qcom/pmic_glink_altmode.c:234:16: error: implicit declaration of
 function 'FIELD_GET'; did you mean 'FOLL_GET'?

tree:   https://github.com/steev/linux sc8280xp-next-20220818
head:   34fef0fd022b76178b8c48819465ec265c5aac2e
commit: 7e91d160800c85329a861246e2225a80e0c842ea [132/159] soc: qcom: pmic_glink: Introduce altmode support
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220819/202208190946.98QZtV0a-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/steev/linux/commit/7e91d160800c85329a861246e2225a80e0c842ea
        git remote add steev https://github.com/steev/linux
        git fetch --no-tags steev sc8280xp-next-20220818
        git checkout 7e91d160800c85329a861246e2225a80e0c842ea
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/soc/qcom/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   drivers/soc/qcom/pmic_glink_altmode.c: In function 'pmic_glink_altmode_sc8180xp_notify':
>> drivers/soc/qcom/pmic_glink_altmode.c:234:16: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
     234 |         port = FIELD_GET(SC8180X_PORT_MASK, notification);
         |                ^~~~~~~~~
         |                FOLL_GET
>> drivers/soc/qcom/pmic_glink_altmode.c:222:13: warning: variable 'svid' set but not used [-Wunused-but-set-variable]
     222 |         u16 svid;
         |             ^~~~
   cc1: some warnings being treated as errors


vim +234 drivers/soc/qcom/pmic_glink_altmode.c

   212	
   213	static void pmic_glink_altmode_sc8180xp_notify(struct pmic_glink_altmode *altmode,
   214						       const void *data, size_t len)
   215	{
   216		struct pmic_glink_altmode_port *alt_port;
   217		const struct usbc_sc8180x_notify *msg;
   218		u32 notification;
   219		u8 orientation;
   220		u8 hpd_state;
   221		u8 hpd_irq;
 > 222		u16 svid;
   223		u8 port;
   224		u8 mode;
   225		u8 mux;
   226	
   227		if (len != sizeof(*msg)) {
   228			dev_warn(altmode->dev, "invalid length of USBC_NOTIFY indication: %zd\n", len);
   229			return;
   230		}
   231	
   232		msg = data;
   233		notification = le32_to_cpu(msg->notification);
 > 234		port = FIELD_GET(SC8180X_PORT_MASK, notification);
   235		orientation = FIELD_GET(SC8180X_ORIENTATION_MASK, notification);
   236		mux = FIELD_GET(SC8180X_MUX_MASK, notification);
   237		mode = FIELD_GET(SC8180X_MODE_MASK, notification);
   238		hpd_state = FIELD_GET(SC8180X_HPD_STATE_MASK, notification);
   239		hpd_irq = FIELD_GET(SC8180X_HPD_IRQ_MASK, notification);
   240	
   241		svid = mux == 2 ? USB_TYPEC_DP_SID : 0;
   242	
   243		if (!altmode->ports[port].altmode) {
   244			dev_dbg(altmode->dev, "notification on undefined port %d\n", port);
   245			return;
   246		}
   247	
   248		alt_port = &altmode->ports[port];
   249		alt_port->orientation = pmic_glink_altmode_orientation(orientation);
   250		alt_port->svid = mux == 2 ? USB_TYPEC_DP_SID : 0;
   251		alt_port->mode = mode;
   252		alt_port->hpd_state = hpd_state;
   253		alt_port->hpd_irq = hpd_irq;
   254		schedule_work(&alt_port->work);
   255	}
   256	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp