linux-kernel - Re: [PATCH v2] drivers: hisilicon: fix mismatch in get/set sgl_sge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yv9tQP6HS9Qps2qY@gondor.apana.org.au>
Date:   Fri, 19 Aug 2022 19:00:16 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Ye Weihua <yeweihua4@...wei.com>
Cc:     wangzhou1@...ilicon.com, shenyang39@...wei.com,
        davem@...emloft.net, tanshukun1@...wei.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers: hisilicon: fix mismatch in get/set sgl_sge_nr

On Thu, Jul 28, 2022 at 10:07:58AM +0800, Ye Weihua wrote:
> KASAN reported this Bug:
> 
> 	[17619.659757] BUG: KASAN: global-out-of-bounds in param_get_int+0x34/0x60
> 	[17619.673193] Read of size 4 at addr fffff01332d7ed00 by task read_all/1507958
> 	...
> 	[17619.698934] The buggy address belongs to the variable:
> 	[17619.708371]  sgl_sge_nr+0x0/0xffffffffffffa300 [hisi_zip]
> 
> There is a mismatch in hisi_zip when get/set the variable sgl_sge_nr.
> The type of sgl_sge_nr is u16, and get/set sgl_sge_nr by
> param_get/set_int.
> 
> Replacing param_get/set_int to param_get/set_ushort can fix this bug.
> 
> Fixes: f081fda293ffb ("crypto: hisilicon - add sgl_sge_nr module param for zip")
> Signed-off-by: Ye Weihua <yeweihua4@...wei.com>
> ---
>  drivers/crypto/hisilicon/zip/zip_crypto.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt