linux-kernel - Re: [PATCH] hwrng: arm-smccc-trng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yv9ta23samZEBgm1@gondor.apana.org.au>
Date:   Fri, 19 Aug 2022 19:00:59 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     James Cowgill <james.cowgill@...ize.com>
Cc:     Olivia Mackall <olivia@...enic.com>,
        Andre Przywara <andre.przywara@....com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Mark Brown <broonie@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwrng: arm-smccc-trng - fix NO_ENTROPY handling

On Mon, Aug 01, 2022 at 08:04:18PM +0000, James Cowgill wrote:
> The SMCCC_RET_TRNG_NO_ENTROPY switch arm is never used because the
> NO_ENTROPY return value is negative and negative values are handled
> above the switch by immediately returning.
> 
> Fix by handling errors using a default arm in the switch.
> 
> Fixes: 0888d04b47a1 ("hwrng: Add Arm SMCCC TRNG based driver")
> Signed-off-by: James Cowgill <james.cowgill@...ize.com>
> ---
>  drivers/char/hw_random/arm_smccc_trng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt